Skip to content

Commit

Permalink
Merge pull request #2558 from EuphoricThinking/benchmark_patch_parame…
Browse files Browse the repository at this point in the history
…ter_for_tests

Add a benchmark scripts parameter for faster testing
  • Loading branch information
pbalcer authored Jan 14, 2025
2 parents ad88f0a + 7371167 commit 02c82d4
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
1 change: 1 addition & 0 deletions scripts/benchmarks/benches/options.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ class Options:
# these two should probably be merged into one setting
stddev_threshold: float = 0.02
epsilon: float = 0.02
iterations_stddev: int = 5

options = Options()

9 changes: 8 additions & 1 deletion scripts/benchmarks/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def main(directory, additional_env_vars, save_name, compare_names, filter):
merged_env_vars = {**additional_env_vars}
intermediate_results: dict[str, list[Result]] = {}
processed: list[Result] = []
for _ in range(5):
for _ in range(options.iterations_stddev):
run_iterations(benchmark, merged_env_vars, options.iterations, intermediate_results)
valid, processed = process_results(intermediate_results, benchmark.stddev_threshold())
if valid:
Expand Down Expand Up @@ -252,6 +252,12 @@ def validate_and_parse_env_args(env_args):
parser.add_argument("--output-html", help='Create HTML output', action="store_true", default=False)
parser.add_argument("--output-markdown", help='Create Markdown output', action="store_true", default=True)
parser.add_argument("--dry-run", help='Do not run any actual benchmarks', action="store_true", default=False)
parser.add_argument(
"--iterations-stddev",
type=int,
help="Max number of iterations of the loop calculating stddev after completed benchmark runs",
default=options.iterations_stddev,
)

args = parser.parse_args()
additional_env_vars = validate_and_parse_env_args(args.env)
Expand All @@ -272,6 +278,7 @@ def validate_and_parse_env_args(env_args):
options.output_markdown = args.output_markdown
options.dry_run = args.dry_run
options.umf = args.umf
options.iterations_stddev = args.iterations_stddev

benchmark_filter = re.compile(args.filter) if args.filter else None

Expand Down

0 comments on commit 02c82d4

Please sign in to comment.