link with Clang static fuzzer lib if UMF_BUILD_FUZZTESTS is set #1284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
force-pushed
the
rrudnick_fuzz_fix
branch
from
b5152e7 to
d31509a
Compare
bratpiorka
changed the title
bratpiorka
force-pushed
the
rrudnick_fuzz_fix
branch
7 times, most recently
from
661b67d to
9a038b3
Compare
bratpiorka
force-pushed
the
rrudnick_fuzz_fix
branch
3 times, most recently
from
0d8eccc to
97d5697
Compare
lukaszstolarczuk
requested changes
Apr 24, 2025
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 4 * * *' | ||
| push: |
| FUZZER_NO_MAIN_LIB | ||
| NAMES libclang_rt.fuzzer_no_main-x86_64.a | ||
| PATHS | ||
| "/usr/lib/llvm-${CMAKE_C_COMPILER_MAJOR_VERSION}/lib/clang/${CMAKE_C_COMPILER_MAJOR_VERSION}/lib/linux/" |
There was a problem hiding this comment.
could we use CMAKE_PREFIX_PATH or some custom var to include here - then in case of error we could print a msg like - "use <var> to set up the path for the clang libs..."
I can imagine that this hardcoded "/usr/lib/llvm-${CMAKE_C_COMPILER_MAJOR_VERSION}/lib..." path will not work on some distros...
| # Fuzzer instrumentation for the whole library | ||
| if(UMF_BUILD_FUZZTESTS | ||
| AND CMAKE_CXX_COMPILER_ID MATCHES "Clang" | ||
| AND LINUX) | ||
| add_compile_options("-fsanitize=fuzzer-no-link") | ||
| add_link_options("-fsanitize=fuzzer-no-link") | ||
|
|
||
| # We need to find the fuzzer lib in the LLVM installation dir and link it | ||
| # statically |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link with the Clang static fuzzer library, libclang_rt.fuzzer_no_main-x86_64, if UMF_BUILD_FUZZTESTS is set.
Additionally, run extra tests in the nightly workflow that would fail without this change.
Successful run: https://github.com/oneapi-src/unified-memory-framework/actions/runs/14616987712/job/41010729530?pr=1284
Fixes: #590