Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enablement of bf16 jit:uni reorders for aarch64 #2104

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Shreyas-fuj
Copy link
Contributor

Description

The PR: #1986 changed a particular condition for bf_16(This was not intended in the PR). So after this was merged some testcases which were going to jin:uni before, started going to simple:any(reference). Therefore, this PR contains the fix for that by just reverting the un-intended change to the original.

Checklist

General

  • [y] Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
make test

99% tests passed, 2 tests failed out of 200

Total Test time (real) = 2142.22 sec

The following tests FAILED:
	159 - test_graph_unit_dnnl_large_partition_usm_cpu (Failed)
	181 - test_benchdnn_modeC_graph_ci_cpu (Failed)
Errors while running CTest
Output from these tests are in: /home/shreyas/G/shr-fuj/oneDNN_open_source/build/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
make: *** [Makefile:71: test] Error 8
  • [y] Have you formatted the code using clang-format?

@Shreyas-fuj Shreyas-fuj requested review from a team as code owners September 20, 2024 08:01
.gitignore Outdated
@@ -16,6 +16,7 @@
#===============================================================================

build
build_acl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a personalised build folder. What is the reason for adding this, and not having cmake nest build folders inside a parent build folder which is already ignored?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @theComputeKid,
I have restored gitignore, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants