Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cpu: {x64,aarch64}: fix debug verbose output #2087

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

atkassen
Copy link
Contributor

@atkassen atkassen commented Sep 6, 2024

Overuse of verbose_printf has led to verbose output like

onednn_verbose,v1,init : onednn_verbose,v1,@@@ type:f32:f32 ndims:3 onednn_verbose,v1,[1:0:0:-1:false:1:1:0:0]onednn_verbose,v1,xonednn_verbose,v1,[1:0:1:-1:false:1:1:0:0]onednn_verbose,v1,xonednn_verbose,v1,[1:0:2:-1:false:1:1:0:0]onednn_verbose,v1, off:0:0
onednn_verbose,v1,norm : onednn_verbose,v1,@@@ type:f32:f32 ndims:3 onednn_verbose,v1,[1:0:0:-1:false:1:1:0:0]onednn_verbose,v1,xonednn_verbose,v1,[1:0:1:-1:false:1:1:0:0]onednn_verbose,v1,xonednn_verbose,v1,[1:0:2:-1:false:1:1:0:0]onednn_verbose,v1, off:0:0
onednn_verbose,v1,smpl : onednn_verbose,v1,@@@ type:f32:f32 ndims:1 onednn_verbose,v1,[1:0:-1:-1:false:1:1:0:0]onednn_verbose,v1, off:0:0
onednn_verbose,v1,tile : onednn_verbose,v1,@@@ type:f32:f32 ndims:1 onednn_verbose,v1,[1:0:-1:-1:false:1:1:0:0]onednn_verbose,v1, off:0:0
onednn_verbose,v1,init : onednn_verbose,v1,@@@ type:f32:f32 ndims:3 onednn_verbose,v1,[1:0:0:-1:false:1:1:0:0]onednn_verbose,v1,xonednn_verbose,v1,[1:0:1:-1:false:1:1:0:0]onednn_verbose,v1,xonednn_verbose,v1,[1:0:2:-1:false:1:1:0:0]onednn_verbose,v1, off:0:0
onednn_verbose,v1,norm : onednn_verbose,v1,@@@ type:f32:f32 ndims:3 onednn_verbose,v1,[1:0:0:-1:false:1:1:0:0]onednn_verbose,v1,xonednn_verbose,v1,[1:0:1:-1:false:1:1:0:0]onednn_verbose,v1,xonednn_verbose,v1,[1:0:2:-1:false:1:1:0:0]onednn_verbose,v1, off:0:0
onednn_verbose,v1,smpl : onednn_verbose,v1,@@@ type:f32:f32 ndims:1 onednn_verbose,v1,[1:0:-1:-1:false:1:1:0:0]onednn_verbose,v1, off:0:0
onednn_verbose,v1,cache: onednn_verbose,v1,@@@ type:f32:f32 ndims:1 onednn_verbose,v1,[1:0:-1:-1:false:1:1:0:0]onednn_verbose,v1, off:0:0

with a lot of extraneous onednn_verbose,v1,s. This PR corrects this and updates the aarch64 debug output to match.

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

@atkassen atkassen added platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64 platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 labels Sep 6, 2024
@atkassen atkassen self-assigned this Sep 6, 2024
@atkassen atkassen requested review from a team as code owners September 6, 2024 23:08
@vpirogov vpirogov added this to the v3.7 milestone Sep 9, 2024
@mgouicem
Copy link
Contributor

Tagging @jondea @theComputeKid @cfRod for review.

Copy link
Contributor

@theComputeKid theComputeKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have never seen/needed this form of verbosity in any testing/profiling but approved nonetheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:cpu-aarch64 Codeowner: @oneapi-src/onednn-cpu-aarch64 platform:cpu-x64 Intel64/AMD64 processors. Codeowner: @oneapi-src/onednn-cpu-x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants