Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to newer docker env syntax #2897

Closed
wants to merge 1 commit into from
Closed

Update to newer docker env syntax #2897

wants to merge 1 commit into from

Conversation

david-cortes-intel
Copy link
Contributor

Description

This PR modifies the example Dockerfile to use the newer syntax for defining environment variables, since the older form ENV K=V is deprecated.

icfaust
icfaust approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@icfaust icfaust left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming green CI steps, merge dependent on necessity, maybe wait for end of freeze?

@Alexsandruss Alexsandruss deleted the docker_env_syntax branch September 16, 2024 14:09
@Alexsandruss
Copy link
Contributor

Deleted due to wrong repo for the PR branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icfaust icfaust icfaust approved these changes

@Alexsandruss Alexsandruss Awaiting requested review from Alexsandruss Alexsandruss is a code owner

@napetrov napetrov Awaiting requested review from napetrov napetrov is a code owner

@homksei homksei Awaiting requested review from homksei homksei is a code owner

@ahuber21 ahuber21 Awaiting requested review from ahuber21 ahuber21 is a code owner

@ethanglaser ethanglaser Awaiting requested review from ethanglaser ethanglaser is a code owner

Assignees
No one assigned
Labels
infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-cortes-intel @Alexsandruss @icfaust