fix: resolve omp simd error in mdd #2894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanglaser
requested review from
Alexsandruss,
napetrov,
homksei and
ahuber21
as code owners
|
Looks simple enough, @ethanglaser could you give a description as to why it needs to only be implemented when MSVC_RT_is_release is true? |
Yes good point, description added |
icfaust
approved these changes
Sep 11, 2024
homksei
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids combination of vectorization and debug mode by only adding omp simd flag when debug flag is not added. This bypasses an error on windows build with -MDd:
using /MTd or /MDd with '#pragma omp simd' may lead to unexpected fails due to the debugging version of iterators that cannot be vectorized correctlyJob without these changes: http://intel-ci.intel.com/ef6eac3e-3f98-f19a-9f5d-a4bf010d0e2e
Job with these changes: http://intel-ci.intel.com/ef6efb69-4c4f-f1a5-b523-a4bf010d0e2e
(only consider windows OneDAL build step, other errors exist for other reasons)