Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflows): add skywalking-eyes license header check #2867

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

homksei
Copy link
Collaborator

@homksei homksei commented Aug 2, 2024

No description provided.

header:
license:
spdx-id: Apache-2.0
copyright-owner: contributors to the oneDAL project
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can it also check that older Intel copyright owner that still exist?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this field so it won't be confusing, as it's not used for check.

@homksei homksei requested a review from napetrov August 3, 2024 19:58
Copy link
Contributor

@napetrov napetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume that overall check works and it would catch copyright that is not compliant

# Clang-format configs
- '.clang-format'
# All .md files
- '**/*.md'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do have md files with copyrights - should we keep them for check? How many failures?

Might be as a next pr discussion on exclusion - fine to merge this one as is

@homksei homksei marked this pull request as draft September 9, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants