Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace internally developed CSR GEMM with a call to MKL #2808

Closed
wants to merge 18 commits into from
Closed

Replace internally developed CSR GEMM with a call to MKL #2808

wants to merge 18 commits into from

Conversation

Vika-F
Copy link
Contributor

@Vika-F Vika-F commented May 31, 2024 •
edited
Loading

  • internally developed GEMM was removed
  • call to MKL's sparse GEMM was added into clusters assignment step in sparse K-means (see assign_clusters kernel)
  • incorrect use of communicator was removed
  • Sparse method was aligned with dense method. Now both methods give the same results on the same input data passed in sparse and dense layout respectively

@Vika-F
Copy link
Contributor Author

Vika-F commented Jun 28, 2024

/azp run CI

@azure-pipelines Azure Pipelines
Copy link

Pipelines were unable to run due to time out waiting for the pull request to finish merging.

@Vika-F
Copy link
Contributor Author

Vika-F commented Jul 2, 2024

/intelci: run

@Vika-F Vika-F marked this pull request as ready for review July 2, 2024 12:16
@Vika-F Vika-F added the dpc++ Issue/PR related to DPC++ functionality label Jul 2, 2024
@Vika-F Vika-F requested review from md-shafiul-alam and removed request for samir-nasibli and Alexsandruss July 2, 2024 12:17
Alexandr-Solovev
Alexandr-Solovev reviewed Jul 3, 2024
View reviewed changes
cpp/oneapi/dal/algo/kmeans/backend/gpu/empty_cluster_handling.hpp Outdated Show resolved Hide resolved
cpp/oneapi/dal/algo/kmeans/backend/gpu/empty_cluster_handling_dpc.cpp Outdated Show resolved Hide resolved
cpp/oneapi/dal/algo/kmeans/backend/gpu/empty_cluster_handling_dpc.cpp Outdated Show resolved Hide resolved
cpp/oneapi/dal/algo/kmeans/backend/gpu/empty_cluster_handling_dpc.cpp Outdated Show resolved Hide resolved
cpp/oneapi/dal/algo/kmeans/backend/gpu/empty_cluster_handling_dpc.cpp Outdated Show resolved Hide resolved
cpp/oneapi/dal/algo/kmeans/backend/gpu/kernels_csr_impl.hpp Outdated Show resolved Hide resolved
cpp/oneapi/dal/algo/kmeans/backend/gpu/infer_kernel_dpc.cpp Outdated Show resolved Hide resolved
cpp/oneapi/dal/algo/kmeans/backend/gpu/kernels_csr_impl.hpp Show resolved Hide resolved
cpp/oneapi/dal/algo/kmeans/backend/gpu/train_kernel_lloyd_csr_dpc.cpp Show resolved Hide resolved
cpp/oneapi/dal/algo/kmeans/backend/gpu/kernels_csr_impl.hpp Outdated Show resolved Hide resolved
@Vika-F
Copy link
Contributor Author

Vika-F commented Jul 4, 2024

/intelci: run

1 similar comment
@Vika-F
Copy link
Contributor Author

Vika-F commented Jul 4, 2024

/intelci: run

@Vika-F
Copy link
Contributor Author

Vika-F commented Jul 5, 2024 •
edited
Loading

Re-run pre-commit: http://intel-ci.intel.com/ef3aa431-06ee-f183-af2d-a4bf010d0e2e

@Vika-F
Copy link
Contributor Author

Vika-F commented Jul 15, 2024

/intelci: run

@Vika-F
Copy link
Contributor Author

Vika-F commented Aug 14, 2024

/intelci: run

@Vika-F Vika-F closed this Oct 28, 2024
@Vika-F
Copy link
Contributor Author

Vika-F commented Oct 28, 2024

The work was moved to #2959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexandr-Solovev Alexandr-Solovev Alexandr-Solovev approved these changes

@md-shafiul-alam md-shafiul-alam Awaiting requested review from md-shafiul-alam

Assignees
No one assigned
Labels
dpc++ Issue/PR related to DPC++ functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vika-F @Alexandr-Solovev