Fixes to growthbook chart to allow use of AWS DocumentDB #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls, fix ingress class params
…terminated upstream on ALB
…S CA cert chain into container if mongo backend is a DocumentDB cluster
…rors even if mongodb.enabled is set to false
AdamStaudt
changed the title
|
@AdamStaudt Thanks for this PR. Could you kindly update the version number before review? |
version number updated. |
bisonlou
reviewed
Oct 5, 2023
| version: ~13.6.1 | ||
| repository: https://charts.bitnami.com/bitnami/ | ||
| condition: mongodb.enabled | ||
| # dependencies: |
There was a problem hiding this comment.
@AdamStaudt great work, I just wonder why you would remove the Mongodb dependency. I just think it should be disabled by default instead. That way it will not be installed for those who do not need it. For those who need it, they could always override the switch
There was a problem hiding this comment.
agreed, it should be diabled by default instead, rather than removed entirely.
oneacrefund-automation
force-pushed
the
main
branch
from
3985c94
to
ae96e73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR contains changes which make it possible to apply the growthbook chart to configure the deployment to use an AWS DocumentDB cluster as its MongoDB backend.
Checklist
Other information