Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/multiple pub web token #1212

Closed
wants to merge 1 commit into from
Closed

Fix/multiple pub web token #1212

wants to merge 1 commit into from

Conversation

calvinlu3
Copy link
Collaborator

@calvinlu3 calvinlu3 added the fix Fix tag for release label Mar 7, 2025
@calvinlu3 calvinlu3 force-pushed the fix/multiple-pub-web-token branch from fafe5fa to a387e92 Compare March 7, 2025 00:29
@calvinlu3 calvinlu3 requested a review from jfkonecn March 7, 2025 01:41
jfkonecn
jfkonecn reviewed Mar 7, 2025
View reviewed changes
Copy link
Contributor

@jfkonecn jfkonecn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So is someone using our api when we're in the middle of creating a new token for them?

@calvinlu3
Copy link
Collaborator Author

So is someone using our api when we're in the middle of create a new token for them?

@jfkonecn Let me look into this issue again. I may have mistakenly thought that the daily cronjob creates a new pub web token if its expired.

@calvinlu3 calvinlu3 marked this pull request as draft March 7, 2025 16:37
@calvinlu3
Copy link
Collaborator Author

Going to close the PR for now because the issue is not reproducible and will revisit when this issue occurs again. The last and only time we saw this exception was in January. The oncokb_public database only has one public website token.

@calvinlu3 calvinlu3 closed this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfkonecn jfkonecn jfkonecn left review comments

Assignees
No one assigned
Labels
fix Fix tag for release
Projects
None yet
Milestone
No milestone
2 participants
@calvinlu3 @jfkonecn