Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore TokenExpiredException in Sentry #1209

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

calvinlu3
Copy link
Collaborator

Resolves oncokb/oncokb#3866

No need to catch this exception in Sentry. It is for the user

@calvinlu3 calvinlu3 requested a review from bprize15 March 1, 2025 19:56
@bprize15
Copy link
Contributor

bprize15 commented Mar 2, 2025

Resolves oncokb/oncokb#3866

No need to catch this exception in Sentry. It is for the user

Could this be useful information that we want to keep track of and report to the user? Ideally, the user should just read the error message, but could it be useful in case the user emails us asking for help?

@calvinlu3
Copy link
Collaborator Author

We intentionally ignore non criticl exceptions like BadCredentialsException and EmailAlreadyUsedException already to reduce noise in our Sentry logs as these are not system failures.
If tracking non critical exceptions is useful for support, then maybe there is a way to categorize exception priority in Sentry (not sure, seems like a valid feature)? Until we see a use case for tracking these, I will just ignore for now?

Copy link
Contributor

@bprize15 bprize15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calvinlu3 calvinlu3 merged commit 5371a4c into oncokb:master Mar 3, 2025
6 checks passed
@calvinlu3 calvinlu3 deleted the ignore-exception branch March 3, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore Sentry Error | TrialAccountExpiredException: Your trial account has expired
2 participants