-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.26 #1203
v4.26 #1203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on the news page script - way easier!
Some changes stilled needed:
- New summary image and update index.html
- Fix ss test
@@ -866,6 +866,7 @@ export type DataRelease = { | |||
}; | |||
|
|||
export const DATA_RELEASES: DataRelease[] = [ | |||
{ date: '02262025', version: 'v4.26' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ date: '02262025', version: 'v4.26' }, | |
{ date: '02272025', version: 'v4.26' }, |
@@ -86,6 +86,7 @@ export default class NewsPage extends React.Component<{ | |||
<CitationText /> | |||
</div> | |||
<div className="mt-2"> | |||
<NewsList date={'02262025'} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<NewsList date={'02262025'} /> | |
<NewsList date={'02272025'} /> |
} from 'app/shared/utils/UrlUtils'; | ||
import { NewlyAddedGenesListItem } from 'app/pages/newsPage/NewlyAddedGenesListItem'; | ||
|
||
export default function NewsContent022025() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may have multiple releases in a month, so may need to add a date in future
closes https://github.com/oncokb/oncokb-pipeline/issues/663
scripts/generate-news-sections.js reads all markdown files and then code generates a react component for each one. Most of the code in the script is to adjust the DOM so that the correct react components are used.