Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.26 #1203

Merged
merged 2 commits into from
Feb 27, 2025
Merged

v4.26 #1203

merged 2 commits into from
Feb 27, 2025

Conversation

jfkonecn
Copy link
Contributor

@jfkonecn jfkonecn commented Feb 18, 2025

closes https://github.com/oncokb/oncokb-pipeline/issues/663

scripts/generate-news-sections.js reads all markdown files and then code generates a react component for each one. Most of the code in the script is to adjust the DOM so that the correct react components are used.

Copy link
Collaborator

@calvinlu3 calvinlu3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the news page script - way easier!

Some changes stilled needed:

  1. New summary image and update index.html
  2. Fix ss test

@@ -866,6 +866,7 @@ export type DataRelease = {
};

export const DATA_RELEASES: DataRelease[] = [
{ date: '02262025', version: 'v4.26' },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ date: '02262025', version: 'v4.26' },
{ date: '02272025', version: 'v4.26' },

@@ -86,6 +86,7 @@ export default class NewsPage extends React.Component<{
<CitationText />
</div>
<div className="mt-2">
<NewsList date={'02262025'} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<NewsList date={'02262025'} />
<NewsList date={'02272025'} />

@jfkonecn jfkonecn changed the title Markdown v4.26 Feb 26, 2025
@jfkonecn jfkonecn marked this pull request as ready for review February 26, 2025 16:47
@jfkonecn jfkonecn requested a review from calvinlu3 February 26, 2025 16:47
} from 'app/shared/utils/UrlUtils';
import { NewlyAddedGenesListItem } from 'app/pages/newsPage/NewlyAddedGenesListItem';

export default function NewsContent022025() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may have multiple releases in a month, so may need to add a date in future

@calvinlu3 calvinlu3 merged commit 4c1e967 into oncokb:master Feb 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants