Add option to delete company #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zhx828 |
jfkonecn
force-pushed
the
add-option-to-delete-company
branch
3 times, most recently
from
753c608 to
d6369ea
Compare
jfkonecn
force-pushed
the
add-option-to-delete-company
branch
2 times, most recently
from
51d99a9 to
068ab6c
Compare
zhx828
requested changes
Mar 4, 2024
src/main/java/org/mskcc/cbio/oncokb/web/rest/CompanyResource.java
Outdated
Show resolved
Hide resolved
src/main/java/org/mskcc/cbio/oncokb/web/rest/CompanyResource.java
Outdated
Show resolved
Hide resolved
jfkonecn
force-pushed
the
add-option-to-delete-company
branch
2 times, most recently
from
879c4c7 to
c0d6d1c
Compare
|
@jfkonecn let me know once it's ready to review again. |
It's ready for review |
next time you could request me to review once ready on the top right corner of this page, I will be notified. Thanks |
zhx828
approved these changes
Mar 5, 2024
| public void delete(Long id) { | ||
| log.debug("Request to delete Company : {}", id); | ||
| Optional<CompanyDTO> maybeCompanyDTO = this.findOne(id); | ||
| if (!maybeCompanyDTO.isPresent()) { | ||
| return; |
There was a problem hiding this comment.
Could you check what's the current behavior when id is not available? Do we throw an exception?
jfkonecn
force-pushed
the
add-option-to-delete-company
branch
from
c0d6d1c to
a2f7a1e
Compare
zhx828
added a commit
to zhx828/oncokb-public
that referenced
this pull request
May 1, 2024
In oncokb#1088, we introduced simpleConfirmModalType which indicates whether it's to update or delete company. When changing license type with user associated, we need to specify the simpleConfirmModalType to UPDATE_COMPANY.
jfkonecn
pushed a commit
to jfkonecn/oncokb-public
that referenced
this pull request
May 13, 2024
In oncokb#1088, we introduced simpleConfirmModalType which indicates whether it's to update or delete company. When changing license type with user associated, we need to specify the simpleConfirmModalType to UPDATE_COMPANY.
jfkonecn
pushed a commit
to jfkonecn/oncokb-public
that referenced
this pull request
Jun 3, 2024
In oncokb#1088, we introduced simpleConfirmModalType which indicates whether it's to update or delete company. When changing license type with user associated, we need to specify the simpleConfirmModalType to UPDATE_COMPANY.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes oncokb/oncokb#3617