Add new ga4 events #161
Merged
Add new ga4 events #161
+231
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…matt-dev-add-new-ga4-events
…matt-dev-add-new-ga4-events
…matt-dev-add-new-ga4-events
…matt-dev-add-new-ga4-events
drbgfc
reviewed
Oct 17, 2024
drbgfc
reviewed
Oct 17, 2024
drbgfc
reviewed
Oct 17, 2024
drbgfc
reviewed
Oct 17, 2024
drbgfc
reviewed
Oct 17, 2024
drbgfc
reviewed
Oct 17, 2024
drbgfc
reviewed
Oct 17, 2024
drbgfc
reviewed
Oct 17, 2024
drbgfc
reviewed
Oct 17, 2024
drbgfc
reviewed
Oct 17, 2024
drbgfc
reviewed
Oct 17, 2024
drbgfc
reviewed
Oct 17, 2024
drbgfc
requested changes
Oct 17, 2024
There was a problem hiding this comment.
Great work man. I know this was a lot of effort and it's much appreciated!
To Do:
1: There are a few minor requests to address in the comments.
2: There is a merge conflict in a single file that needs to be resolved.
Note: One thing to be minful of, which I did not see, but maybe you want ot make a quick pass over, is to ensure that only things were added. In that, no logic paths were changed as a side effect.
…matt-dev-add-new-ga4-events
drbgfc
reviewed
Oct 18, 2024
drbgfc
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.