Add Download XDR Cert shared component #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akanuri9
requested changes
Oct 10, 2024
| @@ -46,6 +48,11 @@ const H2Component = () => { | |||
| const criteriaList = h2CriteriaList.filter((c) => c.selectOption?.includes(selectedOption[0].selectOption)) | |||
| setCriteriaOptions(criteriaList) | |||
| setSelectedCriteria('') | |||
| if (event.target.value === 'Send conversion XDR' || event.target.value === 'Receive conversion XDR') { | |||
There was a problem hiding this comment.
I believe there few others categories in H2 which have XDR related test cases, you can check here https://ett.healthit.gov/ett/#/certification/certh2 as H2 implementation is not yet completed.
akanuri9
reviewed
Oct 14, 2024
| } | ||
|
|
||
| const handleCriteriaChange = (event: SelectChangeEvent) => { | ||
| setSelectedCriteria(event.target.value as string) | ||
| if ( | ||
| event.target.value === 'Criteria (i) XDR Validator' || |
There was a problem hiding this comment.
Instead of adding each criteria, may be you can add a condition such as where the value contains XDR you add the button that way you dont have to worry for any criteria is missed.
akanuri9
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.