FI-3049: Remove automated token introspection tests for SMART v1 #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arscan
reviewed
Aug 28, 2024
| 'authorization server to validate token it has issued.' | ||
| description %( | ||
| Health IT developer demonstrated the ability of the Health IT Module / | ||
| authorization server to validate token it has issued |
There was a problem hiding this comment.
Could we just add here something like: "This is a functional requirement that requires manual inspection because SMART App Launch STU1 does not specify a standard approach to token introspection."
Just so we have somewhere "in the code (and UI)" that describes why SMART v1 does not require token introspection as an additional hint why this works as it does.
arscan
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #553. When using SMART App Launch v1, this branch removes the automated token introspection tests and restores the token introspection attestation.