Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FI-2031: Integrate SMART App Launch Test Kit update #451

Merged
merged 5 commits into from
Aug 8, 2023

Conversation

Jammjammjamm
Copy link
Contributor

This branch updates the g10 suite to accomodate the new inputs included in the SMART App Launch Test Kit 0.3.0 release.

  • For SMART App Launch 1 & 2:
    • A client secret was not required for the EHR Launch with Patient Scopes. This seems like an oversight, and it is now required to match all of the other groups (except public launch)
  • For SMART App Launch 2 only:
    • Locked Client Authentication Type and Client Authentication Encryption Method inputs will be present on most SMART launch groups. The Invalid Token Request and Invalid PKCE Code Verifier groups are the exception and their inputs should appear unchanged.

Systems using the JSON API to run the g10 tests will need to update their API calls to include the new Client Auth Type & Encryption Method inputs if they using SMART App Launch 2. Presets should not need to be updated. The new inputs which need to be added are:

    {
      "name": "client_auth_type",
      "value": "confidential_symmetric",
    },
    {
      "name": "client_auth_encryption_method",
      "value": "ES384",
    },
    {
      "name": "public_client_auth_type",
      "value": "public",
    },

@Jammjammjamm Jammjammjamm self-assigned this Aug 7, 2023
@arscan
Copy link
Contributor

arscan commented Aug 7, 2023

That locked input for the "Client Authentication Encryption Method" in smart v2 technically should be 'N/A', right? (I know we can't do it, but in a perfect world it wouldn't be shown at all or have n/a. I just wonder if people might read into that incorrectly, like they are missing something by not using ES384 for symmetric authentication.

Could you update the description for that input in that specific case to show below such that it says "Only applicable
for Confidential Asymmetric client authentication"

Screenshot 2023-08-07 at 4 27 36 PM

@arscan
Copy link
Contributor

arscan commented Aug 7, 2023

Question 2: Is there a reason why Authorization Method is not locked in the limited access test in smart v2? The description implies that it should be locked. "All other inputs are locked to ensure the same app configuration as in the Standalone Patient App - Full Access test."

@Jammjammjamm Jammjammjamm force-pushed the fi-2031-integrate-smart-update branch from d3f1d5e to f9b6744 Compare August 8, 2023 12:34
@Jammjammjamm Jammjammjamm force-pushed the fi-2031-integrate-smart-update branch from f9b6744 to 520317f Compare August 8, 2023 12:35
@Jammjammjamm Jammjammjamm merged commit 5e43193 into main Aug 8, 2023
3 checks passed
@Jammjammjamm Jammjammjamm deleted the fi-2031-integrate-smart-update branch August 8, 2023 12:37
@arscan arscan mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants