FI-1995: Changes for HL7 validator v6.0.21 #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehall
changed the title
Jammjammjamm
approved these changes
Aug 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validator wrapper is being upgraded to use the most recent version of the HL7 validator (6.0.21 as of now, see inferno-framework/fhir-validator-wrapper#61), and that version of the validator produces some slightly different output compared to the version we previously used (5.6.93):
Code displays that do not match the official display are now errors by default. This can be changed to match the old behavior with the environment variable "DISPLAY_ISSUES_ARE_WARNINGS" set to true.
There's now an error message received when testing US Core 3.1.1 related to a constraint that cannot be met due to a bad profile, see message below. This was seen previously with slightly different text ( https://chat.fhir.org/#narrow/stream/179309-inferno/topic/Pulse.20Oximetry.20Flow.20Rate.20units )
Because we're already ignoring/excluding certain validator messages I added this one to that list.
This is marked as draft until we tag & release a new version of the validator wrapper. (Though technically these should be backwards compatible in the sense that nothing will happen if the environment variable is set on a library that doesn't support it, and ignoring the error message shouldn't have any unexpected effects either)Testing Guidance:
Run the test suites against the inferno reference server and pointing to an updated version of the validator: inferno-framework/fhir-validator-wrapper#61
Ensure all tests pass