Skip to content

Commit

Permalink
FI-2523 Ignore Bulk Data Device resource (#498)
Browse files Browse the repository at this point in the history
* Fix FI-2523

* fix unit test

* Update spec/onc_certification_g10_test_kit/bulk_export_validation_tester_spec.rb

Co-authored-by: Stephen MacVicar <[email protected]>

---------

Co-authored-by: Yunwei Wang <>
Co-authored-by: Stephen MacVicar <[email protected]>
  • Loading branch information
yunwwang and Jammjammjamm authored Mar 6, 2024
1 parent 19b4614 commit d575ceb
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def predefined_device_type?(resource) # rubocop:disable Metrics/CyclomaticComple
end

def determine_profile(resource)
return if resource.resourceType == 'Device' && !predefined_device_type?(resource)
return [] if resource.resourceType == 'Device' && !predefined_device_type?(resource)

select_profile(resource)
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -340,11 +340,11 @@ def suite_options
end

describe '#determine_profile' do
it 'returns nil if given a Device resource that is not predefined' do
it 'returns an empty array if given a Device resource that is not predefined' do
tester.bulk_device_types_in_group = 'not_it'

result = tester.determine_profile(device_resource)
expect(result).to be_nil
expect(result).to be_empty
end

it 'returns the vice profile if given a Device resource that is predefined' do
Expand Down

0 comments on commit d575ceb

Please sign in to comment.