Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

374 Import Manager Update #413

Merged
merged 228 commits into from
Jul 3, 2023
Merged

Conversation

JohnMwashuma
Copy link
Member

@JohnMwashuma JohnMwashuma commented Jun 29, 2023

Fixes #374

Task check list


  • Make race types dynamic, replacing them with electrol races.
  • Add ballots and sub con ballots files to the import work flow.
  • Refactor tally creation logic into separate files based on the type of file being processed and objects being created.
  • Bulk create tally objects to speed up the tally creation process.
  • Use celery to make the import process async, cache elements processed in memcache for the client side to pull the progress.
  • Refactor all references to the Race Type enum to use ballot electrol races election level and sub race.
  • Fix existing failing tests.
  • Add tests for the suggested changes.

Related to


tally_ho/apps/tally/views/super_admin.py Outdated Show resolved Hide resolved
tally_ho/apps/tally/views/super_admin.py Outdated Show resolved Hide resolved
tally_ho/apps/tally/views/super_admin.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Merging #413 (1ed75a1) into master (5de1f34) will increase coverage by 3.62%.
The diff coverage is 71.20%.

@@            Coverage Diff             @@
##           master     #413      +/-   ##
==========================================
+ Coverage   67.09%   70.71%   +3.62%     
==========================================
  Files         123      135      +12     
  Lines        7855     8664     +809     
==========================================
+ Hits         5270     6127     +857     
+ Misses       2585     2537      -48     
Impacted Files Coverage Δ
...ly_ho/apps/tally/views/data/candidate_list_view.py 92.15% <ø> (+4.88%) ⬆️
tally_ho/apps/tally/views/intake.py 89.38% <0.00%> (+1.73%) ⬆️
tally_ho/libs/views/exports.py 14.07% <ø> (-0.36%) ⬇️
tally_ho/urls.py 96.29% <ø> (ø)
tally_ho/apps/tally/views/tally_manager.py 44.07% <19.60%> (+3.81%) ⬆️
...ally/views/reports/administrative_areas_reports.py 33.07% <25.73%> (-1.03%) ⬇️
tally_ho/apps/tally/forms/barcode_form.py 88.63% <50.00%> (-0.50%) ⬇️
tally_ho/libs/utils/active_status.py 62.33% <52.00%> (-11.86%) ⬇️
tally_ho/apps/tally/views/super_admin.py 68.47% <53.96%> (-3.22%) ⬇️
...o/apps/tally/views/data/electrol_race_list_view.py 55.55% <55.55%> (ø)
... and 38 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JohnMwashuma JohnMwashuma force-pushed the 374-make-ballot-types-generic branch from c10a642 to 23882ce Compare June 29, 2023 15:00
@JohnMwashuma JohnMwashuma marked this pull request as ready for review July 3, 2023 06:35
@JohnMwashuma JohnMwashuma force-pushed the 374-make-ballot-types-generic branch from 5bdb3a1 to 1ed75a1 Compare July 3, 2023 07:19
@JohnMwashuma JohnMwashuma force-pushed the 374-make-ballot-types-generic branch from 1ed75a1 to 7eced4e Compare July 3, 2023 07:27
@JohnMwashuma JohnMwashuma merged commit 083c615 into master Jul 3, 2023
@JohnMwashuma JohnMwashuma deleted the 374-make-ballot-types-generic branch July 3, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the tally system to handle new Ballot types more generically
3 participants