Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add race, station and centers filter in and out options #376

Merged
merged 3 commits into from
May 8, 2023

Conversation

lincmba
Copy link
Contributor

@lincmba lincmba commented Apr 27, 2023

Have an extra Races field in the filters that filter out by race type. Duplicate this and reverse the logic to work with filtering results.
The results can be filtered in or out based on race, center or station selected.

Fixes #360
Fixes #358

@lincmba lincmba requested a review from JohnMwashuma April 27, 2023 12:55
@lincmba lincmba force-pushed the add_stations_centers_filters branch from 5c841d0 to 6b9a1f1 Compare May 3, 2023 11:31
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2023

Codecov Report

Merging #376 (c045a51) into master (6197372) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
- Coverage   66.99%   66.89%   -0.10%     
==========================================
  Files         123      123              
  Lines        7526     7537      +11     
==========================================
  Hits         5042     5042              
- Misses       2484     2495      +11     
Impacted Files Coverage Δ
...ally/views/reports/administrative_areas_reports.py 31.92% <0.00%> (-0.35%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lincmba lincmba changed the title Add station and centers filters Add race, station and centers filter in and out options May 5, 2023
@lincmba lincmba requested a review from JohnMwashuma May 5, 2023 10:19
@lincmba lincmba merged commit 7a3c66e into master May 8, 2023
@lincmba lincmba deleted the add_stations_centers_filters branch May 8, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants