Add support for OR operation data filter for date fields
#2704
+186
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvin-muchiri
force-pushed
the
2698-or-filter-date
branch
from
f72e751
to
352a3b4
Compare
fix wrong-import-order / standard import "from builtins import str as text" should be placed before "import six"
fix wrong-import-order / third party import "import six" should be placed before "from onadata.libs.utils.common_tags import KNOWN_DATE_FORMATS"
ukanga
approved these changes
Sep 19, 2024
Merged
kelvin-muchiri
added a commit
that referenced
this pull request
Sep 24, 2024
* add support for querying "or" data by meta data fields * add test * add test * remove extra underscore * add tests * add test * refactor code * add support for ISO date format when filtering data * refactor code * refactor code * refactor code * update documentation * add support for date format %Y-%m-%dT%H:%M:%S%z data endpoint filter * remove unnecessary parsing for dates * revert modified test * update docs * update docs * update docs * update docs * update tests * remove unsupport example from docs * remove tests for unsupported operation * handle invalida date formats when filtering data * rename tests * update doc string * remove commented code * update tag for ona-oidc * enhance error message * fix import lint error fix wrong-import-order / standard import "from builtins import str as text" should be placed before "import six" * fix lint error fix wrong-import-order / third party import "import six" should be placed before "from onadata.libs.utils.common_tags import KNOWN_DATE_FORMATS" * fix indentation * enhance error message * fix lint error line-too-long
kelvin-muchiri
added a commit
that referenced
this pull request
Sep 24, 2024
* add support for querying "or" data by meta data fields * add test * add test * remove extra underscore * add tests * add test * refactor code * add support for ISO date format when filtering data * refactor code * refactor code * refactor code * update documentation * add support for date format %Y-%m-%dT%H:%M:%S%z data endpoint filter * remove unnecessary parsing for dates * revert modified test * update docs * update docs * update docs * update docs * update tests * remove unsupport example from docs * remove tests for unsupported operation * handle invalida date formats when filtering data * rename tests * update doc string * remove commented code * update tag for ona-oidc * enhance error message * fix import lint error fix wrong-import-order / standard import "from builtins import str as text" should be placed before "import six" * fix lint error fix wrong-import-order / third party import "import six" should be placed before "from onadata.libs.utils.common_tags import KNOWN_DATE_FORMATS" * fix indentation * enhance error message * fix lint error line-too-long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Add support for OR operation with date fields when filter on endpoint
/api/v1/dataSteps taken to verify this change does what is intended
Before submitting this PR for review, please make sure you have:
Closes #2698