Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AttributeError: 'ExportBuilder' object has no attribute 'to_google_sheets' #2458

Merged
merged 7 commits into from
Jul 27, 2023

Conversation

kelvin-muchiri
Copy link
Contributor

@kelvin-muchiri kelvin-muchiri commented Jul 26, 2023

Changes / Features implemented

  • Fix AttributeError: 'ExportBuilder' object has no attribute 'to_google_sheets' raised when google export is not enabled by performing validation during data export. Raise 403 HTTP status if validation fails
  • Ignore Flake 8 rule Line break occurred before a binary operator

Steps taken to verify this change does what is intended

  • QA

Side effects of implementing this change

No side effects

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Closes #

@kelvin-muchiri kelvin-muchiri changed the title handle validation for missing google export implementation Fix AttributeError: 'ExportBuilder' object has no attribute 'to_google_sheets' Jul 26, 2023
@kelvin-muchiri kelvin-muchiri merged commit 1813f93 into main Jul 27, 2023
10 checks passed
@kelvin-muchiri kelvin-muchiri deleted the 7647-bug-google-export branch July 27, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants