Add ability to create, update project invitations #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvin-muchiri
force-pushed
the
2425-project-invitation
branch
from
42a858a
to
f281704
Compare
KipSigei
reviewed
May 31, 2023
DavisRayM
reviewed
May 31, 2023
DavisRayM
reviewed
Jun 2, 2023
kelvin-muchiri
changed the title
2 tasks
KipSigei
suggested changes
Jun 23, 2023
KipSigei
previously approved these changes
Jun 26, 2023
kelvin-muchiri
force-pushed
the
2425-project-invitation
branch
from
2580249
to
e084aac
Compare
KipSigei
force-pushed
the
2425-project-invitation
branch
4 times, most recently
from
ed63e3e
to
8ecc0e6
Compare
KipSigei
suggested changes
Jul 20, 2023
onadata/apps/main/signals.py
Outdated
| # pylint: disable=import-outside-toplevel | ||
| from onadata.libs.models.share_project import ShareProject | ||
|
|
||
| for invitation in invitation_qs: |
There was a problem hiding this comment.
can we use queryset_iterator util to iterate through the invitations queryset
KipSigei
approved these changes
Jul 20, 2023
kelvin-muchiri
force-pushed
the
2425-project-invitation
branch
2 times, most recently
from
0bb9537
to
84b1df8
Compare
model to store a project invitation details
there can be multiple revoked invitations. To support this, unique together integrity check has been removed. To prevent duplicate invitations from being created, a validation check has been added to the create invitation endpoint
add missing method docstring
If id and token are invalid or are not provided but the user registers using an email that matches a pending invitation, then that project is shared with the user.
fix failing test
remove PATCH support endpoint /api/v1/projects/{pk}/invitations
update documentation
when the email does not change when updating invitation, the error 'Invitation already exists' occurred. The fix was to have the check for uniqueness only when creating
ensure only pending invitations can be updated
* remove project invitation id and token verification remove invitation_id and invitation_token query params from invitation email link. remove support for allowing a user to register using a different email from the one the invite was sent to add a post_save signal to accept only invitations that match the new user email and remove implementation for accepting invitation from the UserProfileSerializer. This is because a user can also be created using OIDC * update project invitation documentation
fix AttributeError: 'NoneType' object has no attribute 'lower' when creating a user with password field missing from the payload
kelvin-muchiri
force-pushed
the
2425-project-invitation
branch
from
84b1df8
to
9fc5431
Compare
kelvin-muchiri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Steps taken to verify this change does what is intended
Side effects of implementing this change
Ability to create and manage a project invitation resource and send project invitations to unregistered recipients
Before submitting this PR for review, please make sure you have:
Closes #2425