Skip to content

Commit

Permalink
update tests
Browse files Browse the repository at this point in the history
  • Loading branch information
kelvin-muchiri committed Oct 9, 2024
1 parent 2443295 commit 8cccd82
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1806,7 +1806,7 @@ def test_download_from_s3(self, mock_presigned_urls, mock_get_storage_class):
mock_get_storage_class()().bucket.name = "onadata"
request = self.factory.get("/", **self.extra)
response = self.view(request, pk=self.entity_list.pk)
self.assertEqual(response.status_code, 302, response.url)
self.assertEqual(response.status_code, 302)
self.assertEqual(response.url, expected_url)
self.assertTrue(mock_presigned_urls.called)
export = GenericExport.objects.first()
Expand Down
2 changes: 1 addition & 1 deletion onadata/apps/api/tests/viewsets/test_export_viewset.py
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ def test_download_from_s3(self, mock_presigned_urls, mock_get_storage_class):
request = self.factory.get("/export")
force_authenticate(request, user=self.user)
response = self.view(request, pk=export.pk)
self.assertEqual(response.status_code, 302, response.url)
self.assertEqual(response.status_code, 302)
self.assertEqual(response.url, expected_url)
self.assertTrue(mock_presigned_urls.called)
mock_presigned_urls().generate_presigned_url.assert_called_with(
Expand Down
2 changes: 1 addition & 1 deletion onadata/apps/api/tests/viewsets/test_media_viewset.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def test_retrieve_view_from_s3(self, mock_download_url):
)
response = self.retrieve_view(request, pk=self.attachment.pk)

self.assertEqual(response.status_code, 302, response.url)
self.assertEqual(response.status_code, 302)
self.assertEqual(response.url, expected_url)
filename = self.attachment.media_file.name.split("/")[-1]
mock_download_url.assert_called_once_with(
Expand Down

0 comments on commit 8cccd82

Please sign in to comment.