Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to bls license #73

Merged
merged 2 commits into from
Dec 18, 2023
Merged

change to bls license #73

merged 2 commits into from
Dec 18, 2023

Conversation

pld
Copy link
Member

@pld pld commented Dec 15, 2023

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #[issue number]

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Release | Other)

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide

@pld
Copy link
Member Author

pld commented Dec 15, 2023

@Rkareko I'm getting General error during conversion: Unsupported class file major version 64 when running ./gradlew spotlessApply on my cl, any hints?

@Rkareko
Copy link
Contributor

Rkareko commented Dec 18, 2023

@Rkareko I'm getting General error during conversion: Unsupported class file major version 64 when running ./gradlew spotlessApply on my cl, any hints?

This could be an issue caused by the version of java set in the gradle settings of android studio. We currently use Java 11.
This can be set by navigating to the Settings/Preferences dialog, go to Build, Execution, Deployment → Build Tools → Gradle.
Then set the Gradle JDK to java 11 or 17

There is also the fix that had been tried earlier i.e opening the p2p project in Android Studio, then going back to the command line and running it might also work

@pld
Copy link
Member Author

pld commented Dec 18, 2023

k thanks, let me try and figure this out

@pld
Copy link
Member Author

pld commented Dec 18, 2023

yep opening it in Android Studio did it, thanks

@pld pld merged commit b0f6980 into main Dec 18, 2023
1 check passed
@pld pld deleted the update-license branch December 18, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants