Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(aws): Migrate to using OIDC as the recommended auth #21

Merged
merged 2 commits into from
Jul 23, 2024
Merged

doc(aws): Migrate to using OIDC as the recommended auth #21

merged 2 commits into from
Jul 23, 2024

Conversation

ethanholz
Copy link
Contributor

@ethanholz ethanholz commented Jul 23, 2024 •
edited
Loading

No description provided.

@ethanholz ethanholz requested a review from dwhswenson July 23, 2024 17:27
dwhswenson
dwhswenson approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@dwhswenson dwhswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We might need to scrape history to put together an alternative user-based setup if people want that as well, but OIDC is the better default choice.

@dwhswenson dwhswenson merged commit 065a4a8 into omsf-eco-infra:main Jul 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwhswenson dwhswenson dwhswenson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanholz @dwhswenson