Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emojify() misses some emojis in V2 #131

Open
Thomas101 opened this issue May 17, 2023 · 1 comment · May be fixed by #132
Open

emojify() misses some emojis in V2 #131

Thomas101 opened this issue May 17, 2023 · 1 comment · May be fixed by #132
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@Thomas101
Copy link

Hi, I've noticed some emojis fail to decode in version 2 vs version 1, despite being listed in emojilib.

Version 2.0.2
emojify(':airplane_departure: and :flashlight:') -> :airplane_departure: and 🔦

Version 1.11.0
emojify(':airplane_departure: and :flashlight:') -> 🛫 and 🔦

It seems pretty consistent, the position in the string etc seems to make no difference.
@JoshuaKGoldberg JoshuaKGoldberg added the type: bug Something isn't working :( label May 18, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this May 18, 2023
@JoshuaKGoldberg
Copy link
Collaborator

Thanks for the catch! The root issue is that this library is using an older version of emojilib:

node-emoji/package.json

Line 28 in 44800f9

"emojilib": "^2.4.0",

Their 3.X line has newer emojis. So we'll want to switch over.

@JoshuaKGoldberg JoshuaKGoldberg added the status: accepting prs Please, send a pull request to resolve this! label May 18, 2023
@JoshuaKGoldberg JoshuaKGoldberg linked a pull request May 18, 2023 that will close this issue
Draft
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update emojilib to v3 JoshuaKGoldberg/node-emoji
2 participants
@Thomas101 @JoshuaKGoldberg