Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default values to physics shapes and update formatting #238

Merged

Conversation

aaronfranke
Copy link
Member

The goal of this PR is to bring in some of the non-functional changes from #234, making #234 easier to review.

This PR adds default values to the schemas and updates the wording to more closely match KHR/MSFT physics. It also updates the spacing in the Markdown tables to match what's in #234, making that diff easier to review.

This PR contains no functional changes. The default values are already present in the Markdown README file.

I also threw in some lossless optimization of PNG files as a bonus.

@aaronfranke aaronfranke added supporting Non-functional parts of a spec (description, author list, etc) topic:physics labels Nov 29, 2024
@bikemurt
Copy link

I've sat in on a couple of these discussions. One thing I noticed in the PR is that the term "full height" is used when describing the height of a capsule, but not used when describing the height of a cylinder. I think this makes sense, since there's no ambiguity in the case of a cylinder. Maybe there's a way to make the wording more consistent between the two.

I think representing the capsule height as the complete height of the capsule is a lot more intuitive for developers (as opposed to the height between the centers of the hemispheres).

It all makes sense to me, I don't have any comments otherwise.

@aaronfranke aaronfranke force-pushed the physics-shape-default-values branch from e0ae4d3 to 807ce4b Compare November 30, 2024 19:24
@yankscally
Copy link

this is good work as usual,

            "description": "Three number array representing the width, height, and depth of the box (x, y, z).",
            "items": {
                "type": "number",
                "exclusiveMinimum": 0.0
            },
            "minItems": 3,
            "maxItems": 3,
            "default": [ 1.0, 1.0, 1.0 ]
            

I really like this, there is a description for humans, and schemas that could be machine read, hopefully for future applications that may automate how we can use extensions. I would love to see more of this kind of anticipation for using schemas automatically.

@yankscally yankscally self-assigned this Nov 30, 2024
@yankscally yankscally self-requested a review November 30, 2024 22:18
Copy link

@yankscally yankscally left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@aaronfranke aaronfranke merged commit a82567f into omigroup:main Dec 1, 2024
2 checks passed
@aaronfranke aaronfranke deleted the physics-shape-default-values branch December 1, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
supporting Non-functional parts of a spec (description, author list, etc) topic:physics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants