Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows package build permission issue #1260

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

miurahr
Copy link
Member

@miurahr miurahr commented Feb 1, 2025

When building windows package with rootless container, it failed with permission error.
CI/CD use a rootful mode, so it does not affected.

Pull request type

  • Build and release changes -> [build/release]

Which ticket is resolved?

What does this PR change?

  • chore: early detection of container conditions
  • Fix the permission error when running container as rootless mode on development environment.
  • Generated Windows installer exe under build/innosetup/winNoJRE/ become owned by user with uid:gid = 100999.100999. It is a limitation of rootless mode container execution.
  • The detailed discussion is at
    Could not copy "C:\Program Files\Inno Setup 6\SETUP.E32"  amake/innosetup-docker#11

Other information

- Fix the permission error when running container as rootless mode on development environment.
- Generated Windows installer exe under build/innosetup/winNoJRE/ become owned by user with uid:gid = 100999.100999. It is a limitation of rootless mode container execution.
- The detailed discussion is at
amake/innosetup-docker#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant