Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get network slice by name and delete operation were broken #248

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

patriciareinoso
Copy link
Contributor

@patriciareinoso patriciareinoso commented Nov 7, 2024

The issue

The Network Slice is not found (404 error) even if it exists in the DB:

2024-11-07T17:21:00.891+0100	INFO	configapi/api_default.go:192	Get Network Slice by name	{"component": "WebUI", "category": "WebUI"}
2024-11-07T17:21:00.893+0100	INFO	logger/logger.go:92	| 404 |             ::1 | GET     | /config/v1/network-slice/test1 | 	{"component": "WebUI", "category": "GIN"}

DB:

  {
    _id: ObjectId('672ce2ffb9f23a937192049d'),
    'slice-name': 'test1',
    'slice-id': { sst: '1', sd: '102030' },
    'site-device-group': [ 'test1-default' ],
    'site-info': {
      'site-name': 'demo',
      plmn: { mcc: '123', mnc: '11' },
      gNodeBs: [ { name: 'gnb-2', tac: 123 } ],
      upf: { 'upf-port': '123', 'upf-name': 'upf-1' }
    }
  },

Get Network Slice by Name and Delete were broken.

The Fix

After the fix on https://github.com/omec-project/webconsole/pull/244/files (configmodels/model_slice.go), the name of the network slice is stored as slice-name but on the rest of the code SliceName is still used as a filter to retrieve the Network Slices from the DB.

Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gab-arrobo gab-arrobo merged commit 43ab52d into omec-project:main Nov 7, 2024
10 checks passed
1.7.1-dev
1.7.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @patriciareinoso, I just noticed this but when you need to create a new release you only need to delete the -dev part of the version. That is the change should be as follows:

- 1.7.1-dev
+ 1.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants