Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Uses go version from go.mod #38

Merged
merged 3 commits into from
Jan 3, 2024
Merged

chore: Uses go version from go.mod #38

merged 3 commits into from
Jan 3, 2024

Conversation

gruyaume
Copy link
Contributor

@gruyaume gruyaume commented Jan 3, 2024

Description

We use the go version from go.mod instead of specifying it in CI. This makes it so that when we will bump the Go version we will have to do it in less places and therefore avoids potential differences between the go version running in CI and the one in go.mod.

@onf-bot
Copy link
Contributor

onf-bot commented Jan 3, 2024

Can one of the admins verify this patch?

1 similar comment
@onf-bot
Copy link
Contributor

onf-bot commented Jan 3, 2024

Can one of the admins verify this patch?

@gab-arrobo
Copy link
Contributor

ok to test

.github/workflows/master.yml Outdated Show resolved Hide resolved
.github/workflows/master.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@gab-arrobo gab-arrobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gab-arrobo gab-arrobo merged commit 6185183 into omec-project:master Jan 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants