fix: Fix unit tests on go1.21 #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
gatici
approved these changes
Oct 31, 2023
|
retest this please |
|
@onf-bot rebase |
|
@ghislainbourgeois please address conflict |
ghislainbourgeois
force-pushed
the
fix-tests
branch
from
9d216e2
to
a5acf7f
Compare
|
@gab-arrobo I rebased and solved the conflict. |
|
This PR however does not do anything anymore except move a line. I will close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping go4.org/unsafe/assume-no-moving-gc to latest version supporting go1.21. This fixes failing unit tests and support for go1.21. This library does not have any functionality except panicking when run on unknown version of go that might have a moving gc, so this is a safe upgrade.