-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate dataset webclient #5832
Conversation
Last two commits should contain a few additional fixes
|
Working fine for Project and Screen on east-web as described. Since we are using query="Well" elsewhere and WellColumns are called "Well", it is more consistent to use "Image" for ImageColumns. |
No personal objection to unifying towards
|
This reverts commit 3c0632c.
In order to test ome/omero-metadata#5 and in absence of concrete discussion and agreement, 572c319 implements the intermediate solution discussed in #5832 (comment) i.e. acknowledges the fact Project/Dataset tabular data currently exists under two forms and handle both variations. |
@will-moore: is this good to go? |
Yes, this is working for me. |
Thanks, @will-moore. I'll leave you to engage that conversation, creating cards as necessary. |
Summary
Previously opened as #5691, but the metadata population logic has now been filtered out of OMERO.py into an independent component which can be released in isolation (see #5831).
This change cherry-picks the changes at the Webclient level for displaying Tables on P/D/I hierarchy. Minimally, when clicking on the Tables tab on an image, two additional queries are performed to load the bulk annotations at either the Project and/or at the Dataset level.
Testing
Two IDR studies have been imported under the public user of https://web-proxy.openmicroscopy.org/east-web/webclient/: the experimentA of idr0021 and the screenB of idr0008.
For each study, the bulk annotations have been populated using the annotation.csv files under the metadata repositories (idr0021 and idr0008) and omero-metadata:0.2.2
Tables should now load when expanding the corresponding tab in the right-hand panel for:
idr0021
projectidr0008
screen (current behavior)