-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table_name option to ParsingContext() #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor question about the default value. Otherwise this change looks fairly straightforward.
As mentioned in the related PR, I did not find any downstream code that relies on the table name and would be broken by this PR. Instead all downstream code filters by namespace.
Thanks for raising the unused parameters. As it stands, the issue is that omero metadata populate
will pass arguments independently of the selected context so there is a need for some redundant declaration at the moment.
In #59 (comment), I suggested that using **kwargs
might be an option to be lenient about extra parameters and declare only the relevant parameters across Context
implementations.
Thanks. Only two questions are:
|
Added tests |
Now released as https://libraries.io/pypi/omero-metadata/0.9.0 |
See IDR/idr0079-hartmann-lateralline#5 (comment)
Usage:
This change used in IDR/idr0079-hartmann-lateralline@57e507f
to create bulk annotations with custom names:
NB:
ParsingContext()
has several parameters that are not used:fileid
,cfg
,cfgid
,attach
,options
,batch_size
,loops
,ms
. Seems like these should be removed, although that will break code that still includes them.