Plate well labels #543
Plate well labels #543
Conversation
There was a problem hiding this comment.
<li><a href="#" data-label="[well.label] Field#[field.index]">Well & Fieild</a></li>
Mispell of Field
There was a problem hiding this comment.
Also [field.index] is not functional.
Either needs to be changed to [wellsample.index] or could be given an alias in the JS (similar to the comment on run/acquisition)
| @@ -219,11 +219,12 @@ | |||
| format = prop_nf[1] ? prop_nf[1] : "index"; | |||
| precision = param_dict["precision"] !== undefined ? param_dict["precision"] : 0; // decimal places default to 0 | |||
| label_value = self.model.get_time_label_text(format, param_dict["offset"], precision); | |||
| } else if (['image', 'dataset'].includes(prop_nf[0])){ | |||
| } else if (['image', 'dataset', 'screen', 'plate', 'well', 'wellsample'].includes(prop_nf[0])){ | |||
There was a problem hiding this comment.
Could you add acquisition to the list of accepted objects? It's already part of the parent in the JSON response.
And/or the alias run with a ternary condition inside the if:
prop_nf[0] = prop_nf[0] == "run" ? "acquisition" : prop_nf[0]
|
Thanks for the feedback and suggestions @Tom-TBT. |
Fixes #540.
[wellsample.index]label to be[field.index]and to be 1-based instead of 0-based.Excluding to avoid conflicts with #563
--exclude