ScanR: populate exposure times even if field positions are missing #4280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4231.
Compare
showinf -nopix -omexml experiment_descriptor.xmlincurated/scanr/embl/Maik_001with and without this PR. Without this PR, no exposure times should be present in the OME-XML. With this change, aPlaneshould be populated in OME-XML for every plane, and an exposure time should be set for all.This particular plate (and a couple of others, see config PR) appears to legitimately not have physical XY field positions, so conditioning all
Planemetadata population on field positions existing doesn't make sense.