Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect logical operators in Zeiss LSM and OME-XML readers #4214

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Fix incorrect logical operators in Zeiss LSM and OME-XML readers #4214

merged 2 commits into from
Jul 29, 2024

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Jul 22, 2024 •
edited
Loading

Fixes #4209
Fixes #4212

@sbesson sbesson requested a review from melissalinkert July 22, 2024 07:42
@sbesson sbesson changed the title ZeissLSMReader: replace assignment operator by logical and operator Fix incorrect logical operators in Zeiss LSM and OME-XML readers Jul 22, 2024
@joshmoore
Copy link
Member

👏

melissalinkert
melissalinkert approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@melissalinkert melissalinkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections to merging as long as builds remain green tomorrow (just to be safe).

dgault
dgault approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@dgault dgault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, changes look good to me

@dgault dgault added this to the 8.0.0 milestone Jul 22, 2024
@dgault dgault merged commit 0a895ae into ome:develop Jul 29, 2024
18 checks passed
@sbesson sbesson deleted the issue_4209 branch August 14, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melissalinkert melissalinkert melissalinkert approved these changes

@dgault dgault dgault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

May need to replace single | with double || && needed instead of &
4 participants
@sbesson @joshmoore @melissalinkert @dgault