SVS: update isThisType to reject files with a single IFD #4202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See IDR/idr-metadata#699.
With this change, I would expect the files from idr0008 to be detected as "plain" TIFF;
showinf
or similar should initialize and show the image without error. I tested with an artificial file created by:which was enough to demonstrate the original exception, but we may want one of the idr0008 files in the test repo to be safe.
As discussed separately with @sbesson, this is probably the least disruptive way to solve the problem, as it does not require modifying any of the extra image detection logic in
SVSReader
. I would not expect this to introduce any test failures, and it should be safe for a patch release.