SDT: fix NegativeArraySizeException when reading files recorded by SPCM64 9.90 #4198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rded with SPCM 9.90
|
Thanks, @cqian89. This change makes sense to me, so it will be included in tonight's CI builds to see if any of our existing SDT test files are affected. Before merging this pull request, we will need to have a signed Contributor License Agreement. Please submit the CLA according to the instructions here: https://ome-contributing.readthedocs.io/en/latest/cla.html |
|
Thank you. I just submitted the signed CLA as per the instructions. |
melissalinkert
approved these changes
Sep 3, 2024
sbesson
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a java.lang.NegativeArraySizeException when reading files recorded by the latest version (9.90) of Becker Hickl's SPCM64 software. Files recorded with older versions don't seem to have this issue.
On further investigation, it seems to be related to a value setupLength. This should be an unsigned short, but was read as a signed short previously. In the SDT files recorded by the latest SPCM64, this seems to have exceeded the range of a signed short but is still within range of an unsigned short.
This PR fixes the error by changing readShort to readUnsignedShort and the type of setupLength to int.
Test data here: https://doi.org/10.5281/zenodo.12094862