Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matlab Examples #127

Closed
wants to merge 5 commits into from
Closed

Matlab Examples #127

wants to merge 5 commits into from

Conversation

jburel
Copy link
Member

@jburel jburel commented Apr 9, 2024

This PR is built on top of #126 to avoid conflicts.

This PR allows to run the matlab examples on MacOS and Ubuntu using the bf-octave docker image
It takes longer to run the test on Mac since docker needs to be installed.
I can close #126 if we prefer to combine everything in one PR

@jburel jburel requested a review from sbesson April 9, 2024 14:45
@jburel jburel mentioned this pull request Apr 9, 2024
@sbesson sbesson closed this Apr 9, 2024
@sbesson sbesson reopened this Apr 9, 2024
Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should that be a completely separate workflow? There is no relationship to the Java source code and/or the Maven/Ant build system so introducing this as tasks is a bit artificial.

Also, there is no real reason to run these tests for each JDK version since only the JDK of the Docker image should matter

@jburel
Copy link
Member Author

jburel commented Apr 9, 2024

I was thinking to add a new workflow. I put there for convenience for initial review
I will put it in its own workflow

@jburel
Copy link
Member Author

jburel commented Apr 10, 2024

@sbesson matlab tests now run in separate workflow.

@sbesson
Copy link
Member

sbesson commented Apr 10, 2024

From https://github.com/ome/bio-formats-examples/actions/runs/8619991128/job/23625881927?pr=127

warning: function ./test.m shadows a core library function
error: no such file, '/home/octave/src/main/matlab/bftest.m'
error: source: error sourcing file '/home/octave/src/main/matlab/bftest.m'

@jburel
Copy link
Member Author

jburel commented Apr 10, 2024

Thanks. I think we have again a similar problem I had on the octave repo with false positive

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still running into runtime failures

warning: function ./test.m shadows a core library function
error: 'bfCheckJavaPath' undefined near line 1 column 1
error: called from
    /src/main/matlab/bftest.m at line 1 column 1

Thanks. I think we have again a similar problem I had on the octave repo with false positive

Yes the inability to get a failed status above is not great. Going one step further, this makes me consider whether it is valuable to invest in this work at all if we are unable to flag failures as this defies the point of these workflows in the first place. I don't know if the issue lies with GNU Octave, the Docker infrastructure or the way the file is executed.

@jburel
Copy link
Member Author

jburel commented Apr 10, 2024

I will have to check
Anyway i have now adjusted the work. The failure is now expected (but still green) (related to ome/bioformats#4130)

@jburel jburel closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants