Comdb2 addition #184
Comdb2 addition #184
Conversation
Remove an undeclared variable.
… into comdb2_addition
| <!-- Connection details --> | ||
| <dbtype>comdb2</dbtype> | ||
| <driver>com.bloomberg.comdb2.jdbc.Driver</driver> | ||
| <DBUrl><![CDATA[jdbc:comdb2://localhost/tpcc?statement_query_effects=1&verify_retry=1]]></DBUrl> |
There was a problem hiding this comment.
Do you need the CDATA part here?
There was a problem hiding this comment.
The '&' operator causes some XML parsing issue - The 'CDATA' makes XML escape the '&'
log4j.properties
Outdated
| @@ -12,6 +12,7 @@ log4j.logger.com.oltpbenchmark=INFO | |||
| log4j.logger.com.oltpbenchmark.api=INFO | |||
|
|
|||
| # Benchmarks | |||
| log4j.logger.com.oltpbenchmark.benchmarks.tpcc=DEBUG | |||
pom.xml
Outdated
| @@ -150,5 +150,7 @@ | |||
| <artifactId>ojdbc14</artifactId> | |||
| <version>10.2.0.1.0</version> | |||
| </dependency> | |||
|
|
|||
There was a problem hiding this comment.
What did you change in this file?
There was a problem hiding this comment.
No changes - We'll revert this.
| @@ -173,7 +173,7 @@ public void unload(Catalog catalog) throws SQLException { | |||
| Statement st = conn.createStatement(); | |||
| for (Table catalog_tbl : catalog.getTables()) { | |||
| LOG.debug(String.format("Deleting data from %s.%s", workConf.getDBName(), catalog_tbl.getName())); | |||
| String sql = "DELETE FROM " + catalog_tbl.getEscapedName(); | |||
| String sql = "truncate " + catalog_tbl.getEscapedName(); | |||
There was a problem hiding this comment.
There were a number of issues in trying to get TPCH play well with ComDB2 - Most of the changes in the Oltpbench source were our attempts(and suggestions from ComDB2 devs) to get it to work. @QinyuHu and I will revert these changes soon since TPC-H didnt end up working.
There was a problem hiding this comment.
We will revert the changes - they only change "DELETE FROM" to "truncate" for speed up reason. Also System.out was used for debug purpose so we will also revert them.
| @@ -0,0 +1,19 @@ | |||
| <?xml version="1.0"?> | |||
| @@ -229,7 +229,8 @@ public void load() throws SQLException { | |||
| static void truncateTable(String strTable) throws SQLException { | |||
| LOG.debug("Truncating '" + strTable + "' ..."); | |||
| try { | |||
| conn.createStatement().execute("DELETE FROM " + strTable); | |||
| System.out.println("truncate " + strTable); | |||
| @@ -229,7 +229,8 @@ public void load() throws SQLException { | |||
| static void truncateTable(String strTable) throws SQLException { | |||
| LOG.debug("Truncating '" + strTable + "' ..."); | |||
| try { | |||
| conn.createStatement().execute("DELETE FROM " + strTable); | |||
| System.out.println("truncate " + strTable); | |||
| conn.createStatement().execute("truncate " + strTable); | |||
| if (loaders[i] != null) | ||
| loaders[i].start(); | ||
|
|
||
| // for (int i = 0; i < 8; ++i) |
There was a problem hiding this comment.
This part changes the loading from multiple threads at the same time to one at a time. The reason is some unknown issue (till now) of comdb2 (or something between oltp and comdb2) part that stopped multi-thread running. Should we keep some comment here or just revert everything?
… into comdb2_addition
|
@apavlo Prof., unnecessary changes (only TPCH config files for comdb2 remains) have been reverted and other changes also made according to previous comments. |
This pull request provides functionality to benchmark ComDB2 with Oltpbench. The benchmarks worked on are:
TPCC: Fully integrated.Wikipedia: All but one procedure has been integrated. The one procedure not integrated is due to many required features still not being supported by ComDB2.TPCH: Partially Integrated.