Added file mime detection and setting for S3.

olsgreen · Jul 31, 2020 · cd6f852 · cd6f852
1 parent 69ec5c3
commit cd6f852
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 8 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "webpack-s3-pusher",
-  "version": "1.0.1",
+  "version": "1.1.0",
   "description": "A webpack plugin that pushes your packed assets to your S3 bucket, no more, no less.",
   "main": "webpack.s3.pusher.js",
   "scripts": {
@@ -23,6 +23,7 @@
   "license": "MIT",
   "dependencies": {
     "aws-sdk": "^2.291.0",
-    "cli-progress": "^3.0.0"
+    "cli-progress": "^3.0.0",
+    "mime-types": "^2.1.27"
   }
 }
diff --git a/webpack.s3.pusher.js b/webpack.s3.pusher.js
@@ -1,6 +1,7 @@
 const AWS = require('aws-sdk');
 const fs = require('fs');
 const progress = require('cli-progress');
+const mime = require('mime-types');
 
 let s3;
 let bar;
@@ -76,11 +77,9 @@ S3PusherPlugin.prototype.upload = function(filename, content) {
       Body: content
     };
 
-    /**
-     * @todo We should use a MIME sniffer on all files.
-     */
-    if (filename.slice(-3) === 'css') {
-      params.ContentType = 'text/css';
+    let contentType = mime.lookup(filename)
+    if (contentType) {
+        params.ContentType = contentType;
     }
 
     s3.putObject(params, (err, data) => {