Enable windows tests again, the first steps (#528) #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Resolve XDG paths in a OS independent way (using pathlib.Path) * Create directories for config file if it does not exist. * Workaround for removal of tmp XDG files on windows. shutil.rmtree sometimes fails one windows, seems to be UAC related.
|
Excellent! Thank you for working on this. Picked and pushed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow for the CI to run the windows tests again, I've done the bare minimum to get the tox test runner to run again under Windows. There are failing tests but, the purpose of this pull request is just to make it run again.
pathlib.Pathto do all\and/convertions)tmpXDG files on windows.shutil.rmtreesometimes fails one windows, seems to be UAC related.Needs to run on the CI for Linux verdict just tested for python versions 3{6-11} on windows 11 😄