Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomad tx #272

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

nomad tx #272

wants to merge 2 commits into from
+377 −0

Conversation

jlpoltrack
Copy link
Collaborator

Title

brad112358
brad112358 reviewed Feb 3, 2025
View reviewed changes
mLRS/Common/hal/esp/tx-hal-radiomaster-nomad-900-esp32.h Outdated


//-- UARTS
// UARTB = serial port BT/ESP port
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UARTB isn't BT/ESP port here. Should this e changed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, moved to UARTD Serial2

brad112358
brad112358 reviewed Feb 3, 2025
View reviewed changes
mLRS/Common/hal/esp/tx-hal-radiomaster-nomad-900-esp32.h
#define UARTC_TXBUFSIZE 0 // TX FIFO = 128
#define UARTC_RXBUFSIZE TX_COM_RXBUFSIZE

#define UART_USE_SERIAL1 // JR bay pin5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want the UART order here to be the same as the comment above?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well all other HALs use this order with UART after UARTB and UARTC.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pl use the order/sequence as in all hals
it makes it easier for us to be consistent

@olliw42
Copy link
Owner

olliw42 commented Feb 4, 2025 •
edited
Loading

MANY thx.
I'd frankly like to keep that a bit on hold however. We have some other tx-es to work on, and I like to let the tx things settle a bit, lots of stuff were going here recently. And the lr11xx support isn't full yet. No 19Hz7x, and we also should allow switching to 2.4 (dual band we can keep for later). This we can work out better on the rx. And here we also have the C3 thing going on. Lot's of pieces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olliw42 olliw42 olliw42 left review comments

@brad112358 brad112358 brad112358 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlpoltrack @olliw42 @brad112358