-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State the date format explicitly #366
base: main
Are you sure you want to change the base?
Conversation
@sean-hut I'm not aware of places where YYYY-DD-MM is utilized. Where have you seen that in use that would cause this potential confusion? Also, this seems like something for the |
What I am suggesting is that there will be people out there that when Situation:
Outcomes:
It is because of the situation and outcomes described above that I |
Are there? Really? I can't think of a single reason why you would use YYDDMM let alone assume an an unambiguous ISO date would be in that format. |
@olivierlacan sufficient to close this as |
I personally really like a hint to the date format. Nevertheless, I would refine the PR My proposals would be:
|
@@ -5,6 +5,8 @@ All notable changes to this project will be documented in this file. | |||
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|||
This changlog uses the [ISO 8601 date format](https://www.iso.org/iso-8601-date-and-time-format.html) of (YYYY-MM-DD). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo: changlog instead of changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally learned more. The RFC 3339 defines a profile for ISO 8601.
I would propose:
This changelog uses the `full-date` format of [RFC 3339](https://www.rfc-editor.org/rfc/rfc3339#section-5.6), which is `YYYY-MM-DD`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@koppor while your proposal would be technically more precise, I feel it's an overkill due to unnecessary complexity.
Just open your referenced link. Does one really need to know all these semantics to understand that a date (a "full date" that is) is represented as simple as YYYY-MM-DD
?
@@ -5,6 +5,8 @@ All notable changes to this project will be documented in this file. | |||
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|||
This changlog uses the [ISO 8601 date format](https://www.iso.org/iso-8601-date-and-time-format.html) of (YYYY-MM-DD). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shorter version (no need to mention "the changelog" & highlight the format:
This changlog uses the [ISO 8601 date format](https://www.iso.org/iso-8601-date-and-time-format.html) of (YYYY-MM-DD). | |
Dates use the [ISO 8601 date format](https://www.iso.org/iso-8601-date-and-time-format.html) of `YYYY-MM-DD`. |
@@ -5,6 +5,8 @@ All notable changes to this project will be documented in this file. | |||
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|||
This changlog uses the [ISO 8601 date format](https://www.iso.org/iso-8601-date-and-time-format.html) of (YYYY-MM-DD). | |||
|
|||
## [Unreleased] | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @koppor , it should get a change log entry.
### Added | |
- Mention use of [ISO 8601 date format](https://www.iso.org/iso-8601-date-and-time-format.html) (`YYYY-MM-DD`). |
Problem
The ISO 8601 date format is ambiguous for 132 of the days of each year (about a third).
For example 2019-02-10 which is it YYYY-MM-DD or YYYY-DD-MM. The changelog does not say.
Proposed Solution
Explicitly state the date format.
Example
This commit is an example solution.