perf: instantiate a single aiobotocore session

olist · Oct 22, 2023 · cf07425 · cf07425
1 parent b51a1d2
commit cf07425
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/loafer/ext/aws/bases.py b/loafer/ext/aws/bases.py
@@ -4,6 +4,8 @@
 
 logger = logging.getLogger(__name__)
 
+session = get_session()
+
 
 class _BotoClient:
     boto_service_name = None
@@ -21,7 +23,6 @@ def __init__(self, **client_options):
         }
 
     def get_client(self):
-        session = get_session()
         return session.create_client(self.boto_service_name, **self._client_options)
 
 

diff --git a/tests/ext/aws/conftest.py b/tests/ext/aws/conftest.py
@@ -63,9 +63,7 @@ def boto_client_sqs(queue_url, sqs_message):
 
 @pytest.fixture
 def mock_boto_session_sqs(boto_client_sqs):
-    mock_session = mock.Mock()
-    mock_session.create_client.return_value = ClientContextCreator(boto_client_sqs)
-    return mock.patch("loafer.ext.aws.bases.get_session", return_value=mock_session)
+    return mock.patch("loafer.ext.aws.bases.session.create_client", return_value=ClientContextCreator(boto_client_sqs))
 
 
 @pytest.fixture
@@ -78,6 +76,4 @@ def boto_client_sns(sns_publish, sns_list_topics):
 
 @pytest.fixture
 def mock_boto_session_sns(boto_client_sns):
-    mock_session = mock.Mock()
-    mock_session.create_client.return_value = ClientContextCreator(boto_client_sns)
-    return mock.patch("loafer.ext.aws.bases.get_session", return_value=mock_session)
+    return mock.patch("loafer.ext.aws.bases.session.create_client", return_value=ClientContextCreator(boto_client_sns))