Refactor : extracted httpReply function + Improvement : more meaningful error #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is especially useful for first time users who don't know that they should setup a user for this specific script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor : There were many redundant blocks of
echo -ento send the same HTTP headers. Also the hardcodedContent-Lengthis just a bad idea, it's too easy to modify the content and forgetting to change the Content-Lenght. Also it's not obvious for people who don't speak HTTP very fluently how to calculate the Content-Lenght.Improvement : For first time users having a message that suggest setting up the user can be helpful. It would have helped me anyway!