Handle private network preflight call #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chrome has a preflight check for local network requests that requires our loopback listener to respond in a specific way in order to receive the proper GET request. Chrome document: https://developer.chrome.com/blog/private-network-access-preflight/ This document also says we need to include the `Access-Control-Allow-Origin` header as well in order to succeed, but in my (admittedly limited) tests that wasn't necessary. If it's deemed prudent, I can add that to this PR as well.
mikenachbaur-okta
approved these changes
Mar 21, 2024
I just noticed that the return is misaligned... 😞 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome has a preflight check for local network requests that requires our loopback listener to respond in a specific way in order to receive the proper GET request.
Chrome document: https://developer.chrome.com/blog/private-network-access-preflight/
This document also says we need to include the
Access-Control-Allow-Originheader as well in order to succeed, but in my (admittedly limited) tests that wasn't necessary. If it's deemed prudent, I can add that to this PR as well.