Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an operation to Devices API #4096

Merged
merged 5 commits into from
Apr 26, 2023

Conversation

brentschaus-okta
Copy link
Contributor

@brentschaus-okta brentschaus-okta commented Apr 19, 2023

Description

  • What's changed? Adds an operation to the Device API. See Issue 3789.
  • Is this PR related to a Monolith release? No.

Netlify link

https://643f43f5fd2c2722a35aed44--reverent-murdock-829d24.netlify.app/docs/reference/api/devices/#list-all-users-for-a-device

Resolves

@brentschaus-okta
Copy link
Contributor Author

/netlify preview

Copy link

@YangChen-okta YangChen-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @jane-kuang-okta can you take a look too.

@acrolinxdevdocs-okta
Copy link
Contributor

Acrolinx score DRAFT 06.01.22

A minimum Acrolinx Score of 40 is required. The total score is an average of the subscores.

Select Total score to review the Acrolinx scorecard for your article. Try to increase your individual scores, ex. Correctness. Your article will be clearer and more consistent with Microsoft standards.

Article Total score
Required:70
Word and phrases
(Brand, terms)
Preferred: 40
Correctness
(Spelling, grammar)
Preferred: 40
Clarity
(Readability)
Preferred: 10
Inclusive language
(+ accesibility)
Preferred: 10
packages/@okta/vuepress-site/docs/reference/api/devices/index.md 64 72 55 72 56

@acrolinxdevdocs-okta
Copy link
Contributor

Acrolinx score DRAFT 06.01.22

A minimum Acrolinx Score of 40 is required. The total score is an average of the subscores.

Select Total score to review the Acrolinx scorecard for your article. Try to increase your individual scores, ex. Correctness. Your article will be clearer and more consistent with Microsoft standards.

Article Total score
Required:70
Word and phrases
(Brand, terms)
Preferred: 40
Correctness
(Spelling, grammar)
Preferred: 40
Clarity
(Readability)
Preferred: 10
Inclusive language
(+ accesibility)
Preferred: 10
packages/@okta/vuepress-site/docs/reference/api/devices/index.md 78 86 96 83 57

Copy link
Contributor

@brianduffield-okta brianduffield-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small nit

@acrolinxdevdocs-okta
Copy link
Contributor

Acrolinx score DRAFT 06.01.22

A minimum Acrolinx Score of 40 is required. The total score is an average of the subscores.

Select Total score to review the Acrolinx scorecard for your article. Try to increase your individual scores, ex. Correctness. Your article will be clearer and more consistent with Microsoft standards.

Article Total score
Required:70
Word and phrases
(Brand, terms)
Preferred: 40
Correctness
(Spelling, grammar)
Preferred: 40
Clarity
(Readability)
Preferred: 10
Inclusive language
(+ accesibility)
Preferred: 10
packages/@okta/vuepress-site/docs/reference/api/devices/index.md 78 86 96 83 57

@brentschaus-okta brentschaus-okta merged commit 276c778 into master Apr 26, 2023
@brentschaus-okta brentschaus-okta deleted the tbs-okta-602012-add-operation-device-api branch June 5, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants